BUG: Fixed Categorical.Equals with unordered #18822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18822 +/- ##
==========================================
- Coverage 91.56% 91.56% -0.01%
==========================================
Files 150 150
Lines 48942 48947 +5
==========================================
+ Hits 44816 44820 +4
- Misses 4126 4127 +1
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 19, 2017
pandas/core/categorical.py
Outdated
| if self.is_dtype_equal(other): | ||
| if self.categories.equals(other.categories): | ||
| # fastpath to avoid re-coding | ||
| return np.array_equal(self._codes, other._codes) |
There was a problem hiding this comment.
could make this slightly simper
if self.categories.equals(....):
other_codes = other._codes
else:
other_codes = _recode......
return np.array_equal(self._codes, other_codes)
The original issue was already fixed. I added tests to verify (but no whatsnew entry). This addes tests and a fix for pandas-dev#16603 (comment) about `Categorical.equals` Closes pandas-dev#16603
TomAugspurger
force-pushed
the
categorical-equals
branch
from
0ff69a1 to
debae2b
Compare
jreback
requested changes
Dec 29, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| .. _whatsnew_0220: | ||
|
|
||
| v0.22.0 | ||
| ------- |
| @@ -365,7 +365,7 @@ Numeric | |||
| Categorical | |||
| ^^^^^^^^^^^ | |||
|
|
|||
| - | |||
| - Bug in ``Categorical.equals`` between two unordered categories with the same categories, but in a different order (:issue:`16603`) | |||
There was a problem hiding this comment.
We don't list all the Categorical methods in the API docs, and .equals is one of the excluded ones.
|
rebase and push again, fixed some hanging by Travis CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was already fixed. I added tests to verify (but no whatsnew entry).
This addes tests and a fix for #16603 (comment) about
Categorical.equalsCloses #16603